OpenSprinkler Forums Hardware Questions OpenSprinkler Pi (OSPi) All valves engaged on boot Re: Re: All valves engaged on boot

#26626

scottsh
Participant

I wasn’t arguing the bug fix, but the overall concept of having blank station names. I’m thinking it might mess up some UI to have blank names, or make it hard to read. If there is a case for blank names, I was thinking the UIs should do something to handle that (like use a light gray color ‘none’ for the name maybe.)

One thing I noticed was that station names can’t contain commas (because the names are written out as a CSV and any commas aren’t quoted.) If you do, certain UI things like the log display don’t handle that right. Do we want to modify the code to allow commas in the names or should we prevent commas during input validation? Right now I’m assuming no commas in my plugin but I can change that.