[Dutchie30]

A very late reply from me: Adding #include <stdlib.h> (Thx @Marc!) fixed the issue for me too. I’m all for including this in the next release.

[Dutchie30]

It’s the option to do a “quiet” build:

# head -n 11 build.sh 
#!/bin/bash

while getopts ":s" opt; do
  case $opt in
    s)
          SILENT=true
          command shift
      ;;
  esac
done
echo "Building OpenSprinkler..."

It fails without -s too:

# ./build.sh ospi
Building OpenSprinkler...
weather.cpp: In function ‘void getweather_callback(char*)’:
weather.cpp:55:31: error: ‘atoi’ was not declared in this scope
   wt_errCode = atoi(tmp_buffer);
                               ^
weather.cpp:61:22: error: ‘atoi’ was not declared in this scope
   v = atoi(tmp_buffer);
                      ^
weather.cpp:71:22: error: ‘atoi’ was not declared in this scope
   v = atoi(tmp_buffer);
                      ^
weather.cpp:80:22: error: ‘atoi’ was not declared in this scope
   v = atoi(tmp_buffer);
                      ^
weather.cpp:89:31: error: ‘atol’ was not declared in this scope
   uint32_t l = atol(tmp_buffer);
                               ^
weather.cpp:98:22: error: ‘atoi’ was not declared in this scope
   v = atoi(tmp_buffer);
                      ^
weather.cpp:110:22: error: ‘atoi’ was not declared in this scope
   v = atoi(tmp_buffer);
                      ^
Done!

[Dutchie30]

Strange. I’m not confident I’m missing the atoi library. A build of 2.1.8 works as expected on the same host:

[root@opensprinkler OpenSprinkler-Firmware-218]# ./build.sh ospi
Building OpenSprinkler...
Done!

2.1.8 also looks to contain references to atoi in server.cpp, so it looks like I do have the atoi library available. Is it possible the atoi library isn’t declared properly in the new weather.cpp?

[Dutchie30]

Thanks Ray, looking forward to it.

[Dutchie30]

Good to know Samer, thanks!

[Dutchie30]

Thanks Ray, looks to be working. Only thing is that doing git pull; ./build.sh ospi; systemctl restart opensprinkler seems to wipe out the config.

Other than that, awesome job on OpenSprinkler, I’m really looking forward to working with it!

[Author]

Posts