[Samer]

Your absolutely right, complete oversight. I will get this patched up when I get home!

Thank you!

Update: Pushed the fix on my mobile haha! Should work now.

[Samer]

I updated the program selection now and should work everywhere, including iOS! This is for the program preview. If you select the program it will redirect you to the change program window and expand the specific program you selected allowing you to edit it. Minor feature but a nice shortcut.

I also fixed the problem with Android being unable to navigate the timeline/preview. The fix is indirect but I added a navigation menu on the bottom right with a move right/left and zoom in/out button. Tested it on Android and seems to be working well.

Loving the preview page now, thanks for all the feedback!

[Samer]

Not an ideal solution but if it won’t go into a true bridge mode, you could just DMZ the OpenSprinkler’s IP and set a static IP on the WAN interface (the wireless side).

Of course, it would be better to find an option to truly disable routing but hopefully that at least gets some networking up for you.

Edit: This guy seems to have it working in bridge mode: http://www.hongfire.com/forum/showthread.php/411367-SoftwareGuy-s-Review-LB-Link-Chinese-Pocket-802-11n-WiFi-Router. Might help.

[Samer]

@Zapp No problem! Just to give you my scenario, I have almost no wifi in my apartment currently, and my iPhone will spin for a while as well. With the new timeout you will at least be able to tell which end is stalling. If it still spins a lot you know it’s your connection between your phone and your Pi. If the weather just doesn’t load after 5 seconds (empty) then you know the Pi was having issues reaching Yahoo. This is because we capped the server at 5 seconds but did not set a timeout on the phone.

Hope that makes sense, enjoy your party!

Update: I added timeout logic to the javascript (pushed to Github). If the frontend takes more than 5 seconds to get a reply, it stops trying and shows an error. In regard to the weather, this will instead hide the “Loading Weather…” text.

Update 2: I set a hard limit on the PHP execution time. This way, the app should be responsive even after a connection timeout. Long story short, the app should have more control of what is happening rather then leave you with a spinner and no control except for closing/reopening. I really can’t imagine a scenario when the PHP needs more than 5 seconds to execute an action.

[Samer]

Okay, the good news is, your wheel is spinning when you hit a menu item. The bad news is it is indeed the weather lookup locking up the application.

Here is what is going on: the PHP script is fetching the Yahoo weather but it is being delayed for whatever reason. That AJAX call being run prevents other AJAX calls to the same site, from the same browser and as a result you sit there waiting. I will add a timeout to the script now to prevent these lockouts, which might not fix the weather but at least will let the rest of the app function.

My guess: Your connection is being flaky or Yahoo is throttling you (I doubt it but an idea). Try going to Yahoo directly and see if it takes a bit to open or not (refresh it a few times):

http://weather.yahooapis.com/forecastrss?w=23424954

Update: Time out has been added (5 seconds). Let me know if this helps. Again, if the weather times out, it won’t show the weather but the rest of the application will function.

[Samer]

@dman wrote:

Bugs in program preview on Win7 & Chrome
On the program previous screen I get this:[attachment=2:39r2b07v]os4.PNG[/attachment:39r2b07v]

This is not a bug perse, but a feature of Chrome. Each browser gets to handle how to display an input with type date. Chrome and other desktop browsers give you what you captured above. The very right arrow drops down a monthly calendar allowing valid date selection that way.

@dman wrote:

Anyway the up/down button advance/decrement the displayed date. If I advance to 31 Juy (not a date!) I get a screen with Nan for columns:[attachment=1:39r2b07v]preview1.PNG[/attachment:39r2b07v]

The up/down arrow actually increase the values without any error checking. This is okay, normally, because javascript handles overflow on dates correctly. The problem is the way I parse the date afterwards. My app sees 6-31-2013 however javascript sees 7-1-2013.

@dman wrote:

I also get this if I press the blue X next to up/down button – but it then displays:[attachment=0:39r2b07v]preview2.PNG[/attachment:39r2b07v]
Pressing the up/down button still advances the dd part, but leaves the other parts of the format string eg: 02/mm/yyyy

I have now fixed this problem and pushed the update! The preview will not attempt to get data unless a full date is given. I still need to check if that date is valid but it at least wont give NaN for 02/m/yyyy anymore.

@dman wrote:

On Firefox (PC) there is no way to change date apart from actual edit the date on the screen and refresh.

As I said above each browser is different and unfortunately trying to support all of them would be a nightmare. I, personally, am targeting mobile devices with this application and willing to overlook FF, IE, Chrome’s slightly different date input methods.

Update: I just tested Firefox and your right there is no help whatsoever in date input. That really sucks! I could add my own but I really don’t want to load a lot of extra javascript that will only benefit one browser, plus I hate FF.

Update 2: Here is some information on what browser’s support date and other special inputs: http://www.wufoo.com/html5/

Update 3: My previous fix for the NaN issues also works for invalid dates so long the browser supports date input’s. This is because the browser will do validation and set the value to empty on invalid dates. So outside of a few odd scenarios I think I am done worrying about this issue, for now.

[Samer]

@Zapp wrote:

I started to get some issues with the last git pull I did. I often get ‘Loading Weather…’, but no weather, and the webapp sort of freezes. Give it a minute or two and it starts to respond again… I don’t know why, just wanted to give you a heads up.

When you say freezes, are the menus responding or just the weather is frozen? I pull the weather data in using AJAX as to avoid waiting on Yahoo to reply with the weather. To that end, it is entirely possible Yahoo is delaying the weather however if my menu’s are responding that’s a different issue completely. Let me know!

[Samer]

@dman wrote:

You have lots of fans in Australia!!
PS: Yahoo have about 50 codes for snow/rain etc and only one for hot! If they were Aussies it’d be the other way round 😀 (missing ones for very hot, extremely hot and stinkong hot and a few other words!)

Thanks! And in Texas I wish the same thing existed! Pretty darn hot around here.

By the way, the temperature system based on region has been pushed and tested. Seems to be working well, let me know.

@Zapp I actually have done something like that before but since then I have quit instant messaging completely and stopped caring about things like that. The good news is I am actually in talks with Ray to *MAYBE* bring an XMPP protocol to the OpenSprinkler which would open all of the doors your discussing now. Since that would allow alerts to be pushed out it would just be the web app’s coding that would be left. I know Apple has Safari push notifications now that work even if the browser is closed, for web apps. This is an exciting time and hopefully all this tech comes together correctly to allow us notifications without relying on MSN/AIM.

[Samer]

Haha everyone wakes up when I goto sleep 😛

If it doesn’t match a code then nothing happens. The only thing that’ll reset is the code for hot.

By the way, the UI issues with preview I will help address tomorrow however the major thing that bothers me is the scrolling on Android. The others are browser independent issues and are lower priority since the focus is mobile. I will take a look and see what I can do. At the very least I can and will add simple checks for a valid date to get rid of those pesky NaN errors! Will update tomorrow!

Thank you!

[Samer]

@dman Tomorrow, ill add a region detection to the program and use Celsius for anywhere except the US, Bezile, Bermuda, and Palau (Wikipedia listed countries). Should solve the problem without adding another option. I will update when the fix is done.

[Samer]

Just to tack on one more bug, sorry. If I set a master station and then tell all stations to trigger it, only the first 8 stations show up using the master in the preview. I have found the masop variable is only changing for the first board (main board) and not any of the extensions. However, it does have a placeholder for the number of extension boards in place. If I need to clarify let me know, thanks!

[Samer]

I just pushed an update for the preview program that properly shows if a rain delay is preventing a program from running (red and struck out). Figure with all the emphasis on automatic rain delay, I should emphasize rain delay information everywhere.

I enabled master station on the program preview page as well.

Update: I added the program coloring scheme that Ray employes in his program preview. Almost the exact same colors too (minor tweaks for the ones that clashed). I think this brings the program preview all the features Ray’s includes!

[Samer]

That’s it! It’s the program most user’s use with the Raspberry Pi and is also compatible with my mobile app (http://rayshobby.net/phpBB3/viewtopic.php?f=2&t=154, shameless plug :P).

[Samer]

@momanz By the way, I don’t have to worry about interpreting scrolling vs click on the program ID. The operating system does that for me. Normally, iOS has a 300ms delay to decide which gesture your trying to preform. For most of the app, I override that but on the preview page I leave it enabled. Still working on the iOS bug though.

[Samer]

If the weather is returning code 3200 (undefined) then no icon is shown. Try this:

http://weather.yahooapis.com/forecastrss?w=WOEID

Replace WOEID with the code you have (if you know it) and paste the line similar to the one below:

Update: I just resolved your area’s WOEID and got 1102170, which does indeed report 3200. I will see about re-centering the temperature on code 3200 so it at least doesn’t look weird.

Update 2: I pushed an update to remove the allocated space for the image if code 3200 is reported. This should re-center the temperature right above the location and make it look more appropriate.

[Samer]

@momanz wrote:

3) On the program preview graph, it would be really slick if each program bar was a hyperlink to the program edit screen for that program. you would probably need a way to keep attempts to zoom or scroll from activating the hyperlink. Perhaps a tap and hold or double tap? Maybe a configuration switch to disable the feature all together (for those who aren’t interested)?

I just added this feature. One bug, it doesn’t work on iOS, yet. But tested it on desktop and Android and it works great! I will see what I can do about getting it fixed for iOS, not sure whats causing the problem (probably the touch handler for the timeline scrolling).

[Samer]

@Zapp Very excited to hear the automatic rain delay is working!!! 🙂

I love feedback because it helps improve the app for everyone, myself included. For example, I honestly never thought of putting the weather right on the home screen but it has become my new favorite thing!

Glad you enjoy the new changes and keep the feedback coming!

Thanks!

Edit: I pushed an update now to change the format of the log times, it is now exactly like the status page without the seconds.

Edit 2: Your screenshot isn’t showing up, better how? Also, it is probably too large and being blocked, use imgur.com or similar.

Edit 3: Haha! Had me on my toes there 😛

[Samer]

I have also experienced this bug. For me, it happened if I hit stop all stations right after I start a program and requires me to switch enable on/off for it to fully reset back to normal.

I have no clue what would be causing it but that might be an easy way to replicate the issue.

[Samer]

Sounds good, thanks for looking!

Edit: By the way, I added woeid caching to my application, show the current weather on the main page now, and fixed a bug in the auto delay code. Let me know what you think.

[Samer]

Thank you @Zapp for your feedback. I am going to try and address some of your requests:

1) I don’t think the user needs to know what the WOEID is because this is unique to Yahoo! and honestly gibberish otherwise. I do think it would be nice to verify the location however historically this was only passed to the OpenSprinkler. Since I use it for weather now, it would be nice to verify it and I will look into that.

2) Originally, when I designed the auto-delay’s I intended to add current weather page but then decided most people have weather app’s that will be far better then anything I can design. So I canceled that idea. But, what you are suggesting is a nice idea. I plan on adding this at this point, to show the weather where the current tip information is. The tips don’t really show much information so I will just replace the tips with the weather removing the need to disable tips. By the way, Yahoo reports the weather in Fahrenheit, at least using the API link I am using. I suppose I could have javascript convert the number to Celsius but I would have to add an option for that, which we will see about.

3) The dates, especially the logs, were picked on purpose. I needed the most compact date so on the iPhone the whole log line would only take one line of space. To be honest with you I don’t want to make the time format configurable, at least not any time soon. With that said, I have no problem changing the default method to something more people would enjoy. If that is 24 hour time format, let me know and I will make the change. I can’t use the status page’s method because it is too large.

Thank you!

Edit: I pushed an update that shows the weather information (including an image of the current type of weather). This replaces the tips section on the top of the main page. I also cache the WOEID now to prevent the extra HTTP request each time (since the lookup will be frequent). The lookup is done via AJAX so it should not slow down initial page load, waiting for the weather data from Yahoo. I also parse the location from Yahoo and display it, this can be used as a validation for now. I think this addresses points 1 and 2 and leaves point 3 which I am still trying to decide how to address.

Also, the temperature is in Fahrenheit right now but I think I will address the locale issues altogether (time format and measurement units).

The below screenshot shows the new weather as well as the redesigned home menu. Look forward to your feedback!

[Samer]

Kinda love this update I just pushed (https://github.com/salbahra/OpenSprinkler-Controller/commit/7affc27cc2cc41908fb5a9dd8301454e7e7d9e2d) which replaces the station names using @media queries in CSS with numbers on narrow screens for the program preview page. Rotating the screen instantly changes the names back!

Let me know if it works for everyone.

Update: I added some images to demonstrate what I mean.

[Samer]

I think the program your using was intended as a demo and not a 24/7 production program, I could be wrong though. I would implore you to try the interval program available on Ray’s Github instead and see if the same issues exist. Otherwise, you would need some sort of error logs to try and debug the manual mode program your using.

You could run the manual mode program in the foreground instead of in the background and report any errors it might output.

[Samer]

@Zapp Rain sensor, if it is on or off (the current status). While, urs, is the use rain sensor option in the configuration.

[Samer]

@Zapp Thank you! I just pushed the fix.

[Samer]

I want to avoid that, seems too confusing to have them getting keys. At least from my experience.

[Author]

Posts